(usagi-users 01883) Re: Compiling errors in the latest release

[crimsun@xxxxxxxxxxxx]

On Mon, Oct 07, 2002 at 02:27:19PM -0400, Valdis.Kletnieks@xxxxxx wrote:
> On Mon, 07 Oct 2002 10:43:30 PDT, crimsun@xxxxxxxxxxxx  said:
> 
> > If you enable IPSEC, make sure you have CRYPTO and CIPHERS enabled as
> > well.
> 
> Would it be possible to add config magic or #ifdef magic so if you enable
> IPSEC but not the other two, you reach a line
> 
>  #error You must enable CRYPTO and CIPHERS when using IPSEC
> 
> so it dies a quick and ugly (but understandable death?  There's lots of
> similar uses of #error already...

I think the config magic is cleaner and earlier; placing an #error in
ipsec[6].h doesn't catch the missing CONFIG_CRYPTO until the header's
parsed during compile.

Something like the attached patch creates a linkable kernel for me while
still requiring the user to explicitly enable CONFIG_CRYPTO to choose
IPSEC6 support (it's already there for IPSEC).

Comments?

-Dan

-- 
Dan Chen                crimsun@xxxxxxxxxxxx
GPG key:   www.sh.nu/~crimsun/pubkey.gpg.asc

diff -uNr linux.orig/net/ipv6/Config.in linux/net/ipv6/Config.in
--- linux.orig/net/ipv6/Config.in	2002-10-07 20:43:53.000000000 -0400
+++ linux/net/ipv6/Config.in	2002-10-07 21:29:14.000000000 -0400
@@ -88,11 +88,13 @@
 
 # -- IPsec --
 if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
-   if [ "$CONFIG_IPSEC" != "n" ] ; then
-      bool '    IPv6: IP Security Support (EXPERIMENTAL)' CONFIG_IPV6_IPSEC 
-   fi
-   if [ "$CONFIG_IPSEC_TUNNEL" != "n" ]; then
-      define_bool CONFIG_IPV6_IPSEC_TUNNEL y
+   if [ "$CONFIG_CRYPTO" = "y" ]; then
+      if [ "$CONFIG_IPSEC" != "n" ] ; then
+         bool '    IPv6: IP Security Support (EXPERIMENTAL)' CONFIG_IPV6_IPSEC 
+      fi
+      if [ "$CONFIG_IPSEC_TUNNEL" != "n" ]; then
+         define_bool CONFIG_IPV6_IPSEC_TUNNEL y
+      fi
    fi
 fi