[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
(usagi-users 02966) Re: ipv6/udp.c
In article <20040614170636.7e5048f3.davem@xxxxxxxxxx> (at Mon, 14 Jun 2004 17:06:36 -0700), "David S. Miller" <davem@xxxxxxxxxx> says:
> On Mon, 14 Jun 2004 23:55:33 +0900 (JST)
> YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx> wrote:
>
> > Good catch. Thanks.
> >
> > David, please apply this patch.
> ...
> > D: [IPV6] IPSEC: fix double kfree_skb() in error path. (reported by Ken-ichirou MATSUZAWA <chamas@xxxxxxxxxxxxx>)
>
> Applied. Please check 2.4.x, maybe similar bug exists there too.
Thanks.
2.4 does not have this issue.
2.4 uses sock_queue_rcv_skb() and
it does NOT eat if it returns negative value.
while 2.6 uses udpv6_queue_rcv_skb() which always eat skb.
I'll send a patch for 2.4 which replaces sock_queue_rcv_skb() with
udpv6_queue_rcv_skb().
(Note: udpv6_queue_rcv_skb() never returns negative value in 2.4.)
--yoshfuji